Publish PR 10419: fix type in tax_exepctions #10501

marcosmarxm · 2022-02-21T14:30:20Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

abandoned_checkouts customer tax_exemptions had the wrong field type

…airbyte into marcos/test-pr-10419

marcosmarxm · 2022-02-21T14:30:55Z

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1876723395
❌ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1876723395
🐛 https://gradle.com/s/3mwxcom3zzysq

codecov · 2022-02-21T14:36:58Z

Codecov Report

❗ No coverage uploaded for pull request base (master@67b7fc9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #10501   +/-   ##
=========================================
  Coverage          ?   71.42%           
=========================================
  Files             ?        5           
  Lines             ?      406           
  Branches          ?        0           
=========================================
  Hits              ?      290           
  Misses            ?      116           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b7fc9...bc02e11. Read the comment docs.

marcosmarxm · 2022-02-21T14:49:40Z

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1876812275
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1876812275
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_shopify/__init__.py        2      0   100%
source_shopify/transform.py      58      3    95%
source_shopify/utils.py          58      6    90%
source_shopify/auth.py           20      4    80%
source_shopify/source.py        266    102    62%
-------------------------------------------------
TOTAL                           404    115    72%

abandoned_checkouts customer tax_exemptions had the wrong field type

marcosmarxm · 2022-02-22T13:29:36Z

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1881833713
❌ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1881833713

marcosmarxm · 2022-02-23T13:14:03Z

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1887439038
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1887439038

philippeboyd and others added 2 commits February 17, 2022 12:56

fix(shopify): wrong type for tax_exemptions

3089c69

abandoned_checkouts customer tax_exemptions had the wrong field type

Merge branch 'bugfix/tax_exemptions-type' of github.com:philippeboyd/…

49b7787

…airbyte into marcos/test-pr-10419

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 21, 2022

marcosmarxm temporarily deployed to more-secrets February 21, 2022 14:30 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 21, 2022 14:33 Inactive

Merge branch 'master' into marcos/test-pr-10419

db69988

marcosmarxm temporarily deployed to more-secrets February 21, 2022 14:50 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 21, 2022 14:51 Inactive

philippeboyd and others added 3 commits February 21, 2022 14:12

fix(shopify): wrong type for tax_exemptions

ab1bf07

abandoned_checkouts customer tax_exemptions had the wrong field type

merge master and solve conflicts

4091541

bump connector version

ae92f2d

marcosmarxm temporarily deployed to more-secrets February 22, 2022 13:26 Inactive

marcosmarxm temporarily deployed to more-secrets February 22, 2022 13:27 Inactive

solve conflict

bc02e11

marcosmarxm temporarily deployed to more-secrets February 22, 2022 13:30 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 22, 2022 13:32 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 23, 2022 13:16 Inactive

marcosmarxm closed this Feb 23, 2022

marcosmarxm deleted the marcos/test-pr-10419 branch March 23, 2022 16:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Publish PR 10419: fix type in tax_exepctions #10501

Publish PR 10419: fix type in tax_exepctions #10501

marcosmarxm commented Feb 21, 2022

marcosmarxm commented Feb 21, 2022 •

edited by github-actions bot

Loading

codecov bot commented Feb 21, 2022 •

edited

Loading

marcosmarxm commented Feb 21, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Feb 22, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Feb 23, 2022 •

edited by github-actions bot

Loading

Publish PR 10419: fix type in tax_exepctions #10501

Publish PR 10419: fix type in tax_exepctions #10501

Conversation

marcosmarxm commented Feb 21, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

marcosmarxm commented Feb 21, 2022 • edited by github-actions bot Loading

codecov bot commented Feb 21, 2022 • edited Loading

Codecov Report

marcosmarxm commented Feb 21, 2022 • edited by github-actions bot Loading

marcosmarxm commented Feb 22, 2022 • edited by github-actions bot Loading

marcosmarxm commented Feb 23, 2022 • edited by github-actions bot Loading

marcosmarxm commented Feb 21, 2022 •

edited by github-actions bot

Loading

codecov bot commented Feb 21, 2022 •

edited

Loading

marcosmarxm commented Feb 21, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Feb 22, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Feb 23, 2022 •

edited by github-actions bot

Loading